Skip to content

test: slashing release #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Feb 21, 2025
Merged

test: slashing release #374

merged 17 commits into from
Feb 21, 2025

Conversation

0xClandestine
Copy link
Member

No description provided.

0xClandestine and others added 10 commits February 6, 2025 13:46
* test: add utils for testing

* chore: fix remappings

* chore: formatting

* test: add back deployment lib and use operator keys libs

* fix: core deployment lib for tests

* test: clean up config structs for helper lib

* chore: forge fmt

* chore: refactor to avoid stack too deep
…stry coordinator (#384)

* update references from old registryCoordinator to new slashingRegistryCoordinator in SocketRegistry

* update references from old registryCoordinator to new slashingRegistryCoordinator in EjectionManager

* fix: forge fmt

* fix: update IEjectionManager to use new SlashingRegistryCoordinator

* fix: update error string in SocketRegistry unit test
* chore: start refactor

* fix: quorum creation

* fix: bug in registration

* feat: refactor avs sync

* chore: respond to review

* Update src/SlashingRegistryCoordinator.sol

Co-authored-by: Michael Sun <[email protected]>

* fix: m2 registration validity

* feat: lazy migration

* test: fixes and refactor of weightOfOperators

* feat: add updateOperators

* fix: tests and `_afterDeregisterOperator` hook

* refactor: remove operatorSetEnabled as require

* chore: fmt

* chore: fmt test files

* fix: failing ci test

* chore: test fmt

---------

Co-authored-by: Michael Sun <[email protected]>
Co-authored-by: Michael Sun <[email protected]>
* fix: remappings

* fix: remove unused OnlySlasher error (#376)

* refactor: VetoableSlasher (#377)

* chore: use inheritdoc for SlashingRegCoord (#378)

* test: slasher contracts and add some natspec

* chore: unneeded comment

* chore: redundant comments

* test: more extensive setup for slashOperator

* test: integrate core deployment lib

* test: unit test slashing

* test: vetoable slasher

* chore: forge fmt

* chore: format and solve interfaces with inheritdoc

---------

Co-authored-by: clandestine.eth <[email protected]>
Co-authored-by: Noel <[email protected]>
Co-authored-by: Yash Patil <[email protected]>
* test: improve signature checker coverage

* test: improve operator state retriever coverage

* test: improve service manager base coverage

* test: improve service manager base coverage

* chore: forge fmt

* test: improve service manager base coverage

* fix: ci

* test: improve service manager base coverage

* chore: forge fmt
* test: add coverage

* test: add coverage

* chore: forge fmt
nadir-akhtar and others added 6 commits February 7, 2025 12:20
* fix: SocketRegistry-related fixes

* chore: forge fmt + tweak docstrings

* chore(test): remove unnecessary socket registry mock
* chore: refactor middleware deployment for tests

* chore: remove extra vm command

* chore: refactor and cleanup naming

* chore: retrigger ci
* refactor: move forge intense workflow into separate file

* refactor: remove and modify some small details
* test: integration with slashingRegistryCoordinator

* fix: forcederegistration try catch edge cases

* feat: abstract internally

* fix: forcederegister

* test: integration and unit test fixes

* fix: registryCoordinator and forcederegistration

* refactor: _updateStakesAndDeregisterLoiterers

* chore: fmt

* feat: configurable veto delay (#394)

* feat: configurable veto delay

* chore: move things internal and fix tests

* chore: fmt

* chore: move calldata to memory

* feat: move addresses to constructor (#397)

* feat: add nextRequestId to interface

* fix: comments

* fix: tests

* chore: forge fmt

---------

Co-authored-by: gpsanant <[email protected]>
Co-authored-by: Gautham Anant <[email protected]>
Co-authored-by: steven <[email protected]>
Prevents unauthorized cross-AVS registrations when multiple AVSs share
an AVS Registrar.

Changes:
- Add `avs` address to `SlashingRegistryCoordinator` interface
- `avs` value will be used as a consent check to verify registrar
assignment before an AVS can set it
- Associated with the update in the
[core](https://github.com/Layr-Labs/eigenlayer-contracts/pull/1092/files)
contracts that will utilize the getter

ejectOperator in SlashingRegistryCoordinator now only uses
_forceDeregisterOperator, allowing AllocationManager to handle callbacks
for deregistration

This change improves the ejection flow by ensuring proper deregistration
handling through the AllocationManager while maintaining special
handling for M2 quorums on ejection
Copy link
Collaborator

@8sunyuan 8sunyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevennevins stevennevins merged commit 848032a into dev Feb 21, 2025
5 checks passed
@stevennevins stevennevins deleted the test/slashing-release branch February 21, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants