-
Notifications
You must be signed in to change notification settings - Fork 109
test: slashing release #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7b7ec25
to
f004f83
Compare
* test: add utils for testing * chore: fix remappings * chore: formatting * test: add back deployment lib and use operator keys libs * fix: core deployment lib for tests * test: clean up config structs for helper lib * chore: forge fmt * chore: refactor to avoid stack too deep
…stry coordinator (#384) * update references from old registryCoordinator to new slashingRegistryCoordinator in SocketRegistry * update references from old registryCoordinator to new slashingRegistryCoordinator in EjectionManager * fix: forge fmt * fix: update IEjectionManager to use new SlashingRegistryCoordinator * fix: update error string in SocketRegistry unit test
* chore: start refactor * fix: quorum creation * fix: bug in registration * feat: refactor avs sync * chore: respond to review * Update src/SlashingRegistryCoordinator.sol Co-authored-by: Michael Sun <[email protected]> * fix: m2 registration validity * feat: lazy migration * test: fixes and refactor of weightOfOperators * feat: add updateOperators * fix: tests and `_afterDeregisterOperator` hook * refactor: remove operatorSetEnabled as require * chore: fmt * chore: fmt test files * fix: failing ci test * chore: test fmt --------- Co-authored-by: Michael Sun <[email protected]> Co-authored-by: Michael Sun <[email protected]>
* fix: remappings * fix: remove unused OnlySlasher error (#376) * refactor: VetoableSlasher (#377) * chore: use inheritdoc for SlashingRegCoord (#378) * test: slasher contracts and add some natspec * chore: unneeded comment * chore: redundant comments * test: more extensive setup for slashOperator * test: integrate core deployment lib * test: unit test slashing * test: vetoable slasher * chore: forge fmt * chore: format and solve interfaces with inheritdoc --------- Co-authored-by: clandestine.eth <[email protected]> Co-authored-by: Noel <[email protected]> Co-authored-by: Yash Patil <[email protected]>
* test: improve signature checker coverage * test: improve operator state retriever coverage * test: improve service manager base coverage * test: improve service manager base coverage * chore: forge fmt * test: improve service manager base coverage * fix: ci * test: improve service manager base coverage * chore: forge fmt
* test: add coverage * test: add coverage * chore: forge fmt
4b9cdb7
to
292d340
Compare
* fix: SocketRegistry-related fixes * chore: forge fmt + tweak docstrings * chore(test): remove unnecessary socket registry mock
* chore: refactor middleware deployment for tests * chore: remove extra vm command * chore: refactor and cleanup naming * chore: retrigger ci
* refactor: move forge intense workflow into separate file * refactor: remove and modify some small details
* test: integration with slashingRegistryCoordinator * fix: forcederegistration try catch edge cases * feat: abstract internally * fix: forcederegister * test: integration and unit test fixes * fix: registryCoordinator and forcederegistration * refactor: _updateStakesAndDeregisterLoiterers * chore: fmt * feat: configurable veto delay (#394) * feat: configurable veto delay * chore: move things internal and fix tests * chore: fmt * chore: move calldata to memory * feat: move addresses to constructor (#397) * feat: add nextRequestId to interface * fix: comments * fix: tests * chore: forge fmt --------- Co-authored-by: gpsanant <[email protected]> Co-authored-by: Gautham Anant <[email protected]> Co-authored-by: steven <[email protected]>
Prevents unauthorized cross-AVS registrations when multiple AVSs share an AVS Registrar. Changes: - Add `avs` address to `SlashingRegistryCoordinator` interface - `avs` value will be used as a consent check to verify registrar assignment before an AVS can set it - Associated with the update in the [core](https://github.com/Layr-Labs/eigenlayer-contracts/pull/1092/files) contracts that will utilize the getter ejectOperator in SlashingRegistryCoordinator now only uses _forceDeregisterOperator, allowing AllocationManager to handle callbacks for deregistration This change improves the ejection flow by ensuring proper deregistration handling through the AllocationManager while maintaining special handling for M2 quorums on ejection
8sunyuan
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
stevennevins
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.